FIX: エンジンの再起動時にEngineInfoを更新する #1311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
reviewed
May 9, 2023
Member
Hiroshiba
left a comment
Hiroshiba
left a comment
There was a problem hiding this comment.
ほぼLGTMです！！
EngineInfosの情報源がメインプロセスとレンダラープロセスで２重になっているのが問題だなと感じました。
ちょっとこれを課題にあげるIssueを作成してみたいと思います。
（たぶんメイン側でEngineInfoをsetするためのセッターを用意して、set時にレンダラー側にもsetすれば良さそう･･･？）
3 tasks
Contributor
Author
|
関数名を修正しました。 |
Hiroshiba
reviewed
May 12, 2023
Member
Hiroshiba
left a comment
Hiroshiba
left a comment
There was a problem hiding this comment.
LGTM！！
改修ありがとうございます 🙇♂️
たぶん問題ないと思うのでマージします！
Hiroshiba
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
エンジン再起動時にポートが切り替わった場合接続するポートが切り替わらない問題を修正します。
関連 Issue
その他
#1310 の問題により追加エンジンの動作確認ができていません。