Add: vitestでテストが動くように #1074
Merged
Add: vitestでテストが動くように #1074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevenc-nanashi
requested review from
Hiroshiba
and removed request for
a team
Member
Author
|
CIが通るように出来ました |
Member
Author
|
Vitest化できました！ |
Hiroshiba
reviewed
Feb 25, 2023
Hiroshiba
reviewed
Feb 25, 2023
Hiroshiba
reviewed
Feb 25, 2023
Hiroshiba
reviewed
Feb 25, 2023
Hiroshiba
reviewed
Feb 25, 2023
Hiroshiba
reviewed
Feb 25, 2023
Hiroshiba
reviewed
Feb 25, 2023
Member
Hiroshiba
left a comment
Hiroshiba
left a comment
There was a problem hiding this comment.
LibraryPolicy.spec.tsがVuexのstoreをゼロから書く形になっていますが、LibraryPolicyをVuex日依存の形に書き換えるのがやはり良いのかなと思いました！
（関数名などのシグネチャのコピペが大量発生するので、テストが増えれば増えるほど、Vuex側を書き換えづらくなってしまうためです）
提案ですが、このPRはLibraryPolicyの追加と、vitestを通るようにする２つの機能があると思います。
LibraryPolicyの追加は別PRにするというというのはどうでしょう？
Member
Author
ですね、そのほうが色々やりやすい感じがします。 |
Member
やっぱり必要になったときに追加、が綺麗だと思います！ |
Member
Author
|
このPRはHowToUse.spec.tsだけにします。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
LibraryPolicy.vueとHowToUse.vueのテストを追加します。
関連 Issue
スクリーンショット・動画など
（なし）
その他
単体テストを書くのが初めてなので、色々とやっちゃ行けないことをしているかもしれません。