Skip to content

Conversation

mateuszkuprowski
Copy link
Contributor

Per request enabled the possibility of utilisng namespace in pinecone connector

Removed test that would not work
@rbiseck3
Copy link
Contributor

rbiseck3 commented Jan 6, 2025

I thought we already had support for namespaces? What does this PR solve?

@mateuszkuprowski
Copy link
Contributor Author

I thought we already had support for namespaces? What does this PR solve?

We did have it yes, but we never used it from platform perspective, only relying on default namespace behaviour so I wanted to add a test before we put this up in production as a feature (alongside minor refactors I did). Turns out my test fails, so I wonder about the functionality as a whole, trying to find if I was the problem or our upsert.

@mateuszkuprowski
Copy link
Contributor Author

mateuszkuprowski commented Jan 7, 2025

Added passing test verifying that namespaces work correctly. Plus minor refactor in the upsert function and modified descriptions.
Not sure why some of the integration tests are failing, but it has nothing to do with my changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants