Sync Program Class start_Dt and end_Dt #1016

corypride · 2025-10-01T16:13:53Z

Description

Implemented automatic synchronization of class start_dt and end_dt fields when events are rescheduled or cancelled beyond the original class date boundaries. This fixes calendar navigation issues where rescheduled events (like moving Thanksgiving classes into December) were inaccessible because the parent class dates didn't reflect the actual schedule.

Additionally fixed critical bugs related to date discrepancies between dashboard and calendar views, and issues with restored events not properly reverting dates.

Key Changes Made

1. Dynamic RRULE UNTIL Calculation

File: backend/src/database/class_events.go
Function: calculateOriginalEndDate()

Before: Had hardcoded logic for specific date scenarios
After: Implemented dynamic algorithm that works for any RRULE pattern
Improvement: Now calculates the actual last occurrence instead of using hardcoded dates

2. Enhanced Date Boundary Synchronization

Functions Added/Updated:

syncClassDateBoundaries() - Recalculates actual class boundaries
calculateClassBoundariesWithContext() - Handles restore scenarios
updateClassDateBoundaries() - Updates only class date fields
updateRRuleUntilDates() - Updates RRULE UNTIL parameters

3. Multiple Event Series Support

Fixed: Classes with multiple event series now aggregate across ALL series (not just the first one)
Implementation: Changed from .First() to .Find() and loop through all events
Result: More accurate boundary calculations for complex class schedules

4. Improved Timezone Handling

Added: Proper time truncation to avoid timezone issues
Implementation: Truncate(24 * time.Hour) for date-only fields
Benefit: Consistent date handling across different timezones

5. Enhanced Transaction Integration

CreateOverrideEvents() - Syncs after creating/updating overrides
DeleteOverrideEvent() - Syncs after deleting overrides to revert boundaries
Result: Automatic boundary updates on all override operations

Bug Fixes Resolved

1. Date Discrepancy Issue

Problem: Dashboard and calendar views showed different end dates (Nov 27 vs Nov 28)
Root Cause: Different data sources and RRULE UNTIL calculation issues
Solution: Dynamic RRULE UNTIL calculation with proper occurrence handling

2. Restore Events Bug

Problem: Cancelling first event moved start_dt forward, but restoring didn't move it back
Root Cause: Circular dependency using already-modified dates
Solution: Use rRule.OrigOptions.Dtstart as source of truth

3. Multiple Event Series Bug

Problem: Classes with multiple event series only considered the first series
Root Cause: Using .First() instead of .Find()
Solution: Aggregate dates across all event series

Technical Implementation Details

Core Algorithm Flow

Event Override Operation → Trigger boundary sync
Boundary Calculation → Aggregate all occurrences across all series
RRULE Update → Sync UNTIL parameter with actual last occurrence
Class Update → Update start_dt/end_dt to match reality

Key Constants

MaxYearsForInfiniteRRule = 5 - Prevents infinite pattern issues
ClassEndDateBufferMonths = 3 - Allows reasonable override extensions

Error Handling

Graceful handling of malformed RRULEs with warning logs
Fallback to reasonable date ranges when calculations fail
Maintains backward compatibility

Testing Coverage

All integration tests pass, verifying:

✅ Reschedule later extends end date correctly
✅ Cancel/restore functionality works properly
✅ Multiple event series aggregation
✅ RRULE UNTIL synchronization
✅ Date boundary calculations
✅ All 20+ integration test suites (0.816s execution time)

Known Limitations

Manual Date Edits: Class start_dt/end_dt are now computed fields - manual edits through Edit Class form are ignored. To change class dates, admins should reschedule actual events instead.
Initial Creation: Sync only triggers on override operations. Initial event creation with mismatched dates won't auto-correct until first override is created (minor UX issue).

Future Enhancements Considered

Adding sync to CreateNewEvent for initial date correction (kept out of scope)

This implementation provides a robust, maintainable solution that resolves the core date synchronization issues while maintaining full backward compatibility and comprehensive test coverage.

Screenshot(s)

RRuleDateSync.mp4

backend/src/database/class_events.go

jtucholski

@corypride this works pretty well, I noticed one issue:

I set up a recurring class 7 days per wk on 9/1 through 9/30 so the start_dt was 9/1/25
I cancelled the first class. The start_dt was updated to 9/2/25.
I restored the first class. The start_dt was still 9/2/25.

I would have thought the class start_dt goes back to 9/1/25 again.

Also, are you able to include tests that show that the class start_dt and end_dt update when overides are added/removed? We have some existing RRule tests in place so we can probably add it to those?

backend/src/database/class_events.go

CK-7vn

I'd just remove/think about those comments, and it works really well as long as we don't hit a class with multiple events, once that's all fixed it'll be great!

jtucholski

Left a few comments but looks and works great!

backend/src/database/class_events.go

CK-7vn

Quite literally just the same stuff Josh said. Id add that comment so we don't forget to refactor it, add the UTC and make that constant, works great man!

backend/src/database/class_events.go

carddev81

@corypride code looks good, but there are a couple functionality issues when rescheduling the event and restoring that event:

When creating an override event as described in the asana ticket (Nov 1 - 30; override last scheduled event to be December 2). Duplicate events are created. Also when restoring that event, the series is still ending on December 2. See video:

2025-10-15.09-22-57.mp4

backend/src/database/class_events.go

CK-7vn

Just a couple easy things, it works and tests great though!

CK-7vn · 2025-10-20T15:55:25Z

backend/src/database/class_events.go

+
+	originalEndRange := class.StartDt.AddDate(0, 3, 0)
+	if class.EndDt != nil {
+		monthsDiff := int(class.EndDt.Sub(class.StartDt).Hours() / (24 * 30))


We are assuming that all months have 30 days here, this will cause some issues. Example fix:

startYear, startMonth, _ := class.StartDt.Date() endYear, endMonth, _ := class.EndDt.Date() monthsDiff := (endYear-startYear)*12 + int(endMonth-startMonth)

CK-7vn · 2025-10-20T15:57:01Z

backend/src/database/class_events.go

+
+func (db *DB) calculateOriginalEndDate(trans *gorm.DB, classID uint) (time.Time, error) {
+	var events []models.ProgramClassEvent
+	if err := trans.Where("class_id = ?", classID).Find(&events).Error; err != nil {


We should preload Overrides here since we are calling calculateClassBoundariesWithContext(), since both of these methods are called in the same transaction it could cause stale data.

CK-7vn · 2025-10-20T16:05:30Z

backend/src/database/class_events.go

+		newOptions.Until = newUntil
+
+		newRule, err := rrule.NewRRule(newOptions)
+		if err == nil {


I think we should bubble up the error from this, because if we ignore it some events might not get their UNTIL updated, and we won't know why. I don't mind the if err == nil logic, but we should probably and an else just in case.

carddev81 · 2025-10-21T18:00:32Z

@corypride I'm still experiencing the problem from before of duplicating the data. Also I noticed that the days leading up to the changed end date is also being scheduled rather than just the one event. We can discuss the issue and work on it together, this seems like a weird issue that we may need to work out together. Let me know

calisio · 2025-10-22T19:16:16Z

Please let me know when this PR is ready for review, and I will look over it. (waiting because I know you both had a work session today about this).

carddev81

Just have to fix the javascript logic for determining the next scheduled date

carddev81 · 2025-10-23T14:25:04Z

backend/src/database/class_events.go

 }

+func (db *DB) syncClassDateBoundaries(trans *gorm.DB, classID uint) error {
+


just a nit: remove blank line

carddev81 · 2025-10-23T14:46:06Z

backend/src/database/class_events.go

+			updates["end_dt"] = computedEnd
+		}
+	} else {
+		if (!hasOverrides && !ruleUntil.IsZero() && !ruleUntil.Equal(*class.EndDt)) || (!ruleUntil.IsZero() && ruleUntil.After(*class.EndDt)) {


move this up into the else changing it to else if

carddev81 · 2025-10-23T14:52:35Z

backend/src/models/class_event.go

 type ProgramClassEvent struct {
 	DatabaseFields
-	ClassID        uint   `json:"class_id" gorm:"not null" validate:"required"`
+	ClassID        uint   `json:"class_id" gorm:"not null"`


curious why validate:"required" was removed? Can this be added back?

carddev81 · 2025-10-23T15:05:08Z

frontend/src/Components/ClassLayout.tsx

    );

    function getNextOccurrenceDateAsStr(): string {
-        const now = new Date();


Rework to calculate the next scheduled date. You will have to check overrides.

carddev81

@corypride Looks great!! Tests PASSED!!

calisio

I will approve this PR for now, pending that one comment about a large chunk of tests being commented out but still in the code base. I would be curious to hear from the field if canceling a class would move back or forward a start date. I would assume that even if the first class is cancelled, then the start date would remain on the day of the cancelled first class. I think that the only time the start and end dates should change are if there are events that are NOT CANCELLED taking place before or after the start and end date. I will post in slack about this concern.

calisio · 2025-10-30T21:33:18Z

backend/tests/integration/class_date_synchronization_test.go

+	require.True(t, updatedClass.EndDt.After(*createdClass.EndDt), "End date should be later than original November 30")
+}
+
+// // Test that deleting event overrides properly restores class boundaries


why are all of these lines commented out? should we delete them?

…e change and delete

corypride self-assigned this Oct 1, 2025

corypride requested a review from a team as a code owner October 1, 2025 16:13

corypride requested review from calisio and removed request for a team October 1, 2025 16:13

github-actions bot added the Backend label Oct 1, 2025

CK-7vn reviewed Oct 3, 2025

View reviewed changes

backend/src/database/class_events.go Outdated Show resolved Hide resolved

CK-7vn reviewed Oct 3, 2025

View reviewed changes

backend/src/database/class_events.go Outdated Show resolved Hide resolved

CK-7vn reviewed Oct 3, 2025

View reviewed changes

backend/src/database/class_events.go Show resolved Hide resolved

CK-7vn reviewed Oct 3, 2025

View reviewed changes

backend/src/database/class_events.go Outdated Show resolved Hide resolved

CK-7vn reviewed Oct 3, 2025

View reviewed changes

backend/src/database/class_events.go Outdated Show resolved Hide resolved

CK-7vn reviewed Oct 3, 2025

View reviewed changes

backend/src/database/class_events.go Outdated Show resolved Hide resolved

CK-7vn reviewed Oct 3, 2025

View reviewed changes

backend/src/database/class_events.go Outdated Show resolved Hide resolved

CK-7vn reviewed Oct 3, 2025

View reviewed changes

backend/src/database/class_events.go Outdated Show resolved Hide resolved

jtucholski reviewed Oct 3, 2025

View reviewed changes

calisio removed their request for review October 3, 2025 19:34

CK-7vn reviewed Oct 3, 2025

View reviewed changes

backend/src/database/class_events.go Show resolved Hide resolved

CK-7vn reviewed Oct 3, 2025

View reviewed changes

corypride requested review from CK-7vn and jtucholski October 8, 2025 17:16

jtucholski approved these changes Oct 9, 2025

View reviewed changes

backend/src/database/class_events.go Outdated Show resolved Hide resolved

backend/src/database/class_events.go Outdated Show resolved Hide resolved

backend/src/database/class_events.go Show resolved Hide resolved

CK-7vn approved these changes Oct 9, 2025

View reviewed changes

backend/src/database/class_events.go Show resolved Hide resolved

corypride requested review from CK-7vn and jtucholski October 10, 2025 05:24

carddev81 requested review from carddev81 and removed request for jtucholski October 15, 2025 13:44

carddev81 requested changes Oct 15, 2025

View reviewed changes

backend/src/database/class_events.go Outdated Show resolved Hide resolved

corypride force-pushed the cpride/ticket_id478_sync_class_start_dt_and_end_dt branch from a4ea872 to 60bc28a Compare October 20, 2025 03:21

corypride requested a review from carddev81 October 20, 2025 04:34

CK-7vn reviewed Oct 20, 2025

View reviewed changes

CK-7vn self-requested a review October 20, 2025 16:09

corypride force-pushed the cpride/ticket_id478_sync_class_start_dt_and_end_dt branch from ff3c352 to de6fc5c Compare October 20, 2025 19:00

calisio requested review from calisio and removed request for CK-7vn October 22, 2025 17:49

corypride force-pushed the cpride/ticket_id478_sync_class_start_dt_and_end_dt branch from de6fc5c to 2af8772 Compare October 23, 2025 04:24

github-actions bot added the frontend label Oct 23, 2025

corypride force-pushed the cpride/ticket_id478_sync_class_start_dt_and_end_dt branch from 2af8772 to 8eed054 Compare October 23, 2025 04:58

carddev81 requested changes Oct 23, 2025

View reviewed changes

corypride requested a review from carddev81 October 24, 2025 17:13

carddev81 approved these changes Oct 25, 2025

View reviewed changes

calisio approved these changes Oct 30, 2025

View reviewed changes

corypride and others added 6 commits November 3, 2025 11:24

fix: updated backend to handle class start_dt and end_date on schedul…

f426b3b

…e change and delete

fix: removed notes and added some backend tests

1eceafb

fix: requested changes

4261d2a

fix: made requested changes

9ef01eb

fix: removed comments

72b71f2

fix: fixed start_dt logic

43a44b1

corypride force-pushed the cpride/ticket_id478_sync_class_start_dt_and_end_dt branch from 73bb5d0 to 43a44b1 Compare November 3, 2025 17:24

fix: adjusted syncClassDateBoundaries function logic

d6fdec1

carddev81 merged commit d2ad1d9 into main Nov 7, 2025
9 checks passed

carddev81 deleted the cpride/ticket_id478_sync_class_start_dt_and_end_dt branch November 7, 2025 14:46

		}

		func (db DB) syncClassDateBoundaries(trans gorm.DB, classID uint) error {

Sync Program Class start_Dt and end_Dt #1016

Sync Program Class start_Dt and end_Dt #1016

Uh oh!

Conversation

corypride commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Key Changes Made

1. Dynamic RRULE UNTIL Calculation

2. Enhanced Date Boundary Synchronization

3. Multiple Event Series Support

4. Improved Timezone Handling

5. Enhanced Transaction Integration

Bug Fixes Resolved

1. Date Discrepancy Issue

2. Restore Events Bug

3. Multiple Event Series Bug

Technical Implementation Details

Core Algorithm Flow

Key Constants

Error Handling

Testing Coverage

Known Limitations

Future Enhancements Considered

Screenshot(s)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jtucholski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

CK-7vn left a comment

Choose a reason for hiding this comment

Uh oh!

jtucholski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CK-7vn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

carddev81 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

CK-7vn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

carddev81 commented Oct 21, 2025

Uh oh!

calisio commented Oct 22, 2025

Uh oh!

carddev81 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

carddev81 left a comment

corypride commented Oct 1, 2025 •

edited

Loading