chore: Optimize NetworkVariable property accessors #3689
+218
−210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Optimize property accessors around
NetworkVariable
m_NetworkBehaviour
,m_NetworkObject
andm_NetworkManager
CanWrite
andCannotWrite
to aggressively inlined functionsm_UseServerTime
boolean that can be calculated once rather than on every check on the NetworkVarNetowrkVariableDeltaMessage
to reduce indentation and increase readability.Jira ticket
Needs a JIRA ticket
Changelog
Documentation
Testing & QA (How your changes can be verified during release Playtest)
These changes are less risky and should be covered by the automated testing.
Functional Testing
Manual testing :
Manual testing done
Automated tests:
Covered by existing automated tests
Covered by new automated tests
Does the change require QA team to:
Review automated tests
?Execute manual tests
?Provide feedback about the PR
?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports
This is a performance improvement so backporting this fix isn't necessary.