Skip to content

Conversation

glabute
Copy link
Collaborator

@glabute glabute commented Oct 9, 2025

Purpose of this PR

CMCL-1721

Creating a new Cinemachine asset in the project window now has the same look and feel as creating a new MonoBehaviour

Testing status

  • Added an automated test
  • Passed all automated tests
  • Manually tested

Documentation status

  • Updated CHANGELOG
  • Updated README (if applicable)
  • Commented all public classes, properties, and methods
  • Updated user documentation

Technical risk

low

@u-pr-agent
Copy link
Contributor

u-pr-agent bot commented Oct 9, 2025

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

The PR is a small, straightforward refactor that replaces custom logic with a standard Unity Editor API, making it very easy to review and validate.
🏅 Score: 100

This is an excellent refactor that correctly replaces a complex, non-standard implementation with the proper Unity Editor API, improving code maintainability and providing a more consistent user experience.
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent

Co-authored-by: u-pr-agent[bot] <205906871+u-pr-agent[bot]@users.noreply.github.com>
@codecov-github-com
Copy link

codecov-github-com bot commented Oct 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...emachine/Editor/Utility/ScriptableObjectUtility.cs 0.00% 9 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1091      +/-   ##
==========================================
- Coverage   17.24%   17.22%   -0.02%     
==========================================
  Files         209      209              
  Lines       23721    23679      -42     
==========================================
- Hits         4090     4079      -11     
+ Misses      19631    19600      -31     
Flag Coverage Δ
cinemachine_MacOS_2022.3 ?
cinemachine_MacOS_6000.0 ?
cinemachine_MacOS_6000.2 ?
cinemachine_MacOS_6000.3 ?
cinemachine_MacOS_6000.4 ?
cinemachine_Ubuntu_2022.3 ?
cinemachine_Ubuntu_6000.0 ?
cinemachine_Ubuntu_6000.2 ?
cinemachine_Ubuntu_6000.3 ?
cinemachine_Ubuntu_6000.4 ?
cinemachine_Windows_2022.3 17.27% <0.00%> (+0.02%) ⬆️
cinemachine_Windows_6000.0 17.16% <0.00%> (+0.02%) ⬆️
cinemachine_Windows_6000.2 17.16% <0.00%> (+0.02%) ⬆️
cinemachine_Windows_6000.3 17.16% <0.00%> (+0.02%) ⬆️
cinemachine_Windows_6000.4 17.16% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...emachine/Editor/Utility/ScriptableObjectUtility.cs 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@glabute glabute merged commit 2a36e44 into main Oct 13, 2025
43 of 44 checks passed
@glabute glabute deleted the dev/createnewasset-refactor branch October 13, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant