Skip to content

Conversation

@glabute
Copy link
Collaborator

@glabute glabute commented Jul 29, 2025

Purpose of this PR

CMCL-1709: Some [Delayed] attributes were missing.

Testing status

  • Added an automated test
  • Passed all automated tests
  • Manually tested

Documentation status

  • Updated CHANGELOG
  • Updated README (if applicable)
  • Commented all public classes, properties, and methods
  • Updated user documentation

Technical risk

none

@codecov-github-com
Copy link

codecov-github-com bot commented Jul 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1074      +/-   ##
==========================================
- Coverage   23.52%   23.51%   -0.01%     
==========================================
  Files         228      228              
  Lines       27323    27320       -3     
==========================================
- Hits         6427     6424       -3     
  Misses      20896    20896              
Flag Coverage Δ
Ubuntu_trunk 23.47% <ø> (ø)
cinemachine_MacOS_2022.3 ?
cinemachine_MacOS_6000.0 ?
cinemachine_MacOS_6000.1 ?
cinemachine_MacOS_6000.2 ?
cinemachine_MacOS_6000.3 ?
cinemachine_Ubuntu_2022.3 17.06% <ø> (ø)
cinemachine_Ubuntu_6000.0 16.95% <ø> (ø)
cinemachine_Ubuntu_6000.1 16.95% <ø> (ø)
cinemachine_Ubuntu_6000.2 16.95% <ø> (ø)
cinemachine_Ubuntu_6000.3 16.95% <ø> (ø)
cinemachine_Windows_2022.3 ?
cinemachine_Windows_6000.0 ?
cinemachine_Windows_6000.1 ?
cinemachine_Windows_6000.2 ?
cinemachine_Windows_6000.3 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...achine/Runtime/Behaviours/CinemachineDecollider.cs 0.00% <ø> (ø)
...achine/Runtime/Behaviours/CinemachineDeoccluder.cs 44.44% <ø> (ø)
...achine/Runtime/Behaviours/CinemachineRecomposer.cs 0.00% <ø> (ø)
...time/Behaviours/CinemachineShotQualityEvaluator.cs 0.00% <ø> (ø)
...ne/Runtime/Behaviours/CinemachineThirdPersonAim.cs 0.00% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@glabute glabute merged commit b4f8919 into main Jul 29, 2025
44 of 45 checks passed
@glabute glabute deleted the dev/add-some-missing-delayed-attributes branch July 29, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants