CMCL-1706: Added InputAxisControllerBase.GetController() and InputAxisControllerBase.TriggerRecentering() #1072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Base.TriggerRecentering
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1072 +/- ##
=======================================
Coverage ? 27.32%
=======================================
Files ? 256
Lines ? 28865
Branches ? 0
=======================================
Hits ? 7888
Misses ? 20977
Partials ? 0
🚀 New features to boost your workflow:
|
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #1072 +/- ##
==========================================
+ Coverage 17.04% 23.52% +6.48%
==========================================
Files 209 228 +19
Lines 23920 27323 +3403
==========================================
+ Hits 4076 6427 +2351
- Misses 19844 20896 +1052
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 42 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
CMCL-1706: Reported on Discussions:
https://discussions.unity.com/t/inputaxis-triggerrecentering-doesnt-animate/945363/9
The issue was that while recentering got triggered, lingering input from the InputAxisController decelerator would read as new user input, immediately causing the recentering to be halted.
The fix is to add a new method to InputAxisController, which both cancels the lingering input and triggers the recentering.
Testing status
Documentation status
Technical risk
low - just added new API