Skip to content

Two minor endian-adjacent fixes #3150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Two minor endian-adjacent fixes #3150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a23278
nc_test4/tst_h5_endians.c: Fix missing "return retval" line
neuschaefer Jul 19, 2025
c4d51b9
libdispatch/dvar.c: Choose less confusing definition of endianness
neuschaefer Jul 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libdispatch/dvar.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,7 +738,7 @@ nc_def_var_chunking(int ncid, int varid, int storage, const size_t *chunksizesp)
/**
Define endianness of a variable.

With this function the endianness (i.e. order of bits in integers) can
With this function the endianness (i.e. order of bytes in integers) can
be changed on a per-variable basis. By default, the endianness is the
same as the default endianness of the platform. But with
nc_def_var_endianness the endianness can be explicitly set for a
Expand Down
1 change: 1 addition & 0 deletions nc_test4/tst_h5_endians.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,7 @@ int main() {
if ((retval = nc_put_var(ncid,be_int_varid,idata_in)))
return retval;
if ((retval = nc_get_var(ncid,be_int_varid,idata_be_out)))
return retval;
for(failed=0,i=0;i<NDIM;i++) {if(idata_in[i] != idata_be_out[i]) {printf("failed\n"); failures++; failed++; break;}}
if(!failed) printf("passed\n");

Expand Down
Loading