Skip to content

Minor -- fix UNset to unset #2856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Minor -- fix UNset to unset #2856

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,7 +568,7 @@ if(DEFINED PLUGIN_INSTALL_DIR)
if(boolval)
set(ENABLE_PLUGIN_INSTALL YES)
# No actual value was specified
UNset(PLUGIN_INSTALL_DIR CACHE)
unset(PLUGIN_INSTALL_DIR CACHE)
else()
if(boolval STREQUAL "NOTFOUND")
# Must be an actual value
Expand All @@ -583,7 +583,7 @@ endif()

# Ensure no defined plugin dir if not enabled
if(NOT ENABLE_PLUGIN_INSTALL)
UNset(PLUGIN_INSTALL_DIR CACHE)
unset(PLUGIN_INSTALL_DIR CACHE)
endif()

if(ENABLE_PLUGIN_INSTALL)
Expand Down Expand Up @@ -615,8 +615,8 @@ if(ENABLE_PLUGIN_INSTALL)
set(PLUGIN_INSTALL_DIR_SETTING "${PLUGIN_INSTALL_DIR}")
message("Final value of-DPLUGIN_INSTALL_DIR=${PLUGIN_INSTALL_DIR}")
else() # No option specified
UNset(PLUGIN_INSTALL_DIR)
UNset(PLUGIN_INSTALL_DIR CACHE)
unset(PLUGIN_INSTALL_DIR)
unset(PLUGIN_INSTALL_DIR CACHE)
set(PLUGIN_INSTALL_DIR_SETTING "N.A.")
endif()

Expand Down Expand Up @@ -696,7 +696,7 @@ endif()
if (NOT ENABLE_S3 AND ENABLE_NCZARR_S3)
set(ENABLE_S3 ON CACHE BOOL "NCARR S3" FORCE) # For back compatibility
endif()
UNset(ENABLE_NCZARR_S3)
unset(ENABLE_NCZARR_S3)

if(NOT ENABLE_REMOTE_FUNCTIONALITY)
message(WARNING "ENABLE_REMOTE_FUNCTIONALITY=NO => disable all s3 functionality")
Expand Down