Skip to content

Conversation

wx4stg
Copy link
Contributor

@wx4stg wx4stg commented Jul 28, 2023

This fixes bunkers storm motion returning nan when given a nan in the input data.

I don't believe any documentation is necessary for this as it is not documented in other functions that remove nans automatically.

@wx4stg wx4stg requested a review from a team as a code owner July 28, 2023 05:27
@wx4stg wx4stg requested review from dcamron and removed request for a team July 28, 2023 05:27
Copy link
Member

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change seems fine. Can you add a test that represents the use case that prompted this?

@dopplershift dopplershift added Type: Enhancement Enhancement to existing functionality Area: Calc Pertains to calculations labels Jul 28, 2023
@dopplershift dopplershift added this to the September 2023 milestone Jul 28, 2023
@dopplershift dopplershift merged commit 2809552 into Unidata:main Aug 15, 2023
@dopplershift
Copy link
Member

Congratulations on your first merged Pull Request to MetPy! 🎉 I'm working on getting through the others. Definitely hope to continue to see you around!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Calc Pertains to calculations Type: Enhancement Enhancement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants