Fix compatibility with future Pint #2496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pint has restructured and removed the `.unit` submodule. We were only using that to get around defining a percent unit, which works using standard syntax now--and we don't need to support older Pint versions with our workaround any more.
dopplershift
added
Type: Maintenance
dopplershift
added
the
backport
|
🏁 Successfully backported as #2570. 🏁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Pint has restructured and removed the
.unitsubmodule. We were only using that to get around defining a percent unit, which works using standard syntax now--and we don't need to support older Pint versionswith our workaround any more.
Checklist
[ ] Tests added[ ] Fully documented