Replace use of Dataset.apply and .drop to clear PendingDeprecationWarnings #1441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jthielen
added
Type: Maintenance
dopplershift
approved these changes
Aug 3, 2020
Collaborator
Author
|
@dopplershift Any idea with what's up with the second Travis CI check showing as queued, but then links to the completed job on Travis's site? Looks like same thing as #1430. |
Member
|
I’m not sure what’s up with Travis, but it’s the kind of thing that gets it relegated to second class status, or even turned off. Every seems to be passing as expected in the actual builds. |
dcamron
reviewed
Aug 3, 2020
|
|
||
|
|
||
| def test_distances_from_cross_section_given_bad_coords(test_cross_xy): | ||
| """Ensure an AttributeError is raised when the cross section lacks neeed coordinates.""" |
Member
There was a problem hiding this comment.
Not your change, but looks like we dropped a letter there.
Member
There was a problem hiding this comment.
By all means put in a PR for that.
Collaborator
Author
There was a problem hiding this comment.
Hey, it's cross sections, so the git blame is probably mine anyways!
dcamron
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
As alluded to in #1430 (comment), bumping xarray's minimum version to 0.14.1 allows us to clear out some
PendingDeprecationWarningsdue to our usage ofDataset.applyandDataset.drop, so that's what I've done here. From running the test suite locally, it goes fromto
Not sure if I should add any direct testing that these warnings are no longer issued?
Checklist