MNT:(deps): Bump cartopy from 0.17.0 to 0.18.0 in /ci #1416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
force-pushed
the
dependabot-pip-ci-cartopy-0.18.0
branch
from
08d560f to
825a3ae
Compare
Bumps [cartopy](https://github.com/SciTools/cartopy) from 0.17.0 to 0.18.0. - [Release notes](https://github.com/SciTools/cartopy/releases) - [Commits](SciTools/cartopy@v0.17.0...v0.18.0) Signed-off-by: dependabot[bot] <[email protected]>
CartoPy 0.18 started validating scales for NaturalEarthFeature, which breaks with the scales for our own map features. There's really no reason to inherit from NaturalEarthFeature, so just make this inherit Feature and add a few missing things.
For reasons, CartoPy needs NumPy installed first.
Matplotlib (as of 3.2.2) does not properly clip text to paths. For now, add a clipbox for the Axes bounding box, which will supplement the set clip path.
0.18 started autoscaling map features and updated some gridline handling, causing changes to our test images.
Matplotlib <3.3 checks for closed contours using floating point equality. For *this test*, this was causing different results on macOS vs. Windows/Linux. Fixing this actually changes the labelling of another closed contour as well.
Needed for CartoPy 0.18 + Matplotlib 2. This is mostly issues with slight changes to clipping, plus some barb things.
dopplershift
force-pushed
the
dependabot-pip-ci-cartopy-0.18.0
branch
from
5a9c233 to
1a64c53
Compare
dopplershift
approved these changes
Jul 27, 2020
Member
dopplershift
left a comment
dopplershift
left a comment
There was a problem hiding this comment.
Finally have CartoPy 0.18 fixes merged!
This was referenced Jul 27, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps cartopy from 0.17.0 to 0.18.0.
Release notes
Sourced from cartopy's releases.
Commits
178a15eSet date for release 0.18.0.e26a8b4Avoid some pyplot calls in examples.ec8dfb9DOC: Fix reST syntax for a list.e6c1d06Merge pull request #1536 from QuLogic/circle-verboseb8c9b1eDrop Python 2 doc builds on CI entirely.68a2165Merge pull request #1529 from stefraynaud/new_example_ticklabels24a2514Simplify gridliner example's feature creation.c3a0d08Merge pull request #1535 from QuLogic/clip-inlined52480dMerge pull request #1534 from greglucas/update_to_mpl33692220bGetting rid of warnings within tests for MPL 3.3Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)