Refactor xarray grid deltas calculation to handle axis order flexibly #1260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
added
Area: Xarray
This was referenced Jan 10, 2020
dopplershift
previously approved these changes
Jan 13, 2020
Member
dopplershift
left a comment
dopplershift
left a comment
There was a problem hiding this comment.
Looks good, just a minor question.
src/metpy/calc/tools.py
Outdated
| latitude = np.asarray(latitude) | ||
|
|
||
| # Determine dimension order for offset slicing | ||
| take_y = make_take(latitude.ndim, kwargs.pop('y_dim', -2)) |
Member
There was a problem hiding this comment.
Think this and x_dim could become a kwarg-only argument?
Collaborator
Author
There was a problem hiding this comment.
Sure. Looking back at this, I'm not sure why I did it the way it is now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
As noted in #1249 (comment), the grid deltas calculation does not handle dimension/axis order that are not (..., y, x), whereas a goal of MetPy's xarray integration is to be able to flexibly handle dimension order. This PR refactors
lat_lon_grid_deltasandgrid_deltas_from_dataarrayto now flexibly handle dimension order. There were also some accompanying changes:find_axis_numberhelper (similar tofind_axis_name) has been added to the DataArray accessorkindargument togrid_deltas_from_dataarray, which has options "actual" and "nominal" to pave the way for Generalize vorticity (and related functions) to allow for map projections #893bump minimum xarray version to 0.13.0, which is needed for Pint Quantities to be inside xarray objects(doesn't quite work with Pint v0.9)axis/axesargument documentation to fully resolve Documentation for axes in gradient calc #1249Checklist