Fix compare method for reference free models #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix compare method for reference free models
|
@ricardorei please review |
Open
| "{} requires -r/--references or -d/--sacrebleu_dataset.".format(cfg.model) | ||
| ) | ||
|
|
||
| references = cfg.references if cfg.references is not None else None |
There was a problem hiding this comment.
references = cfg.references or None
There was a problem hiding this comment.
thanks, I'd refactor if I make another PR here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running the comet compare model for reference free model, and was getting error. Upon debugging this appeared like a bug to me, because the checks for reference model was already there.
Command i used
comet-compare -s src.ps -t hyp1.hi hyp2.hi --model Unbabel/wmt22-cometkiwi-da
Error
Traceback (most recent call last):
File "/Library/Frameworks/Python.framework/Versions/3.12/bin/comet-compare", line 8, in
sys.exit(compare_command())
^^^^^^^^^^^^^^^^^
File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/comet/cli/compare.py", line 501, in compare_command
if references is not None:
^^^^^^^^^^
UnboundLocalError: cannot access local variable 'references' where it is not associated with a value