Fix multi-gpu inference #178
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes multi-gpu inference, as reported in #177
While trying to fix it, I found some more errors related to proper handling of error spans metadata (with XCOMET models).
I tried out the fixes with XCOMET-XL and wmt22-comet-da models - but it could use some more testing (the code could also be somewhat improved, but I haven't mastered the COMET codebase yet ;) )