-
-
Notifications
You must be signed in to change notification settings - Fork 391
OMRChecker v2.0.0 #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Udayraj123
wants to merge
275
commits into
master
Choose a base branch
from
dev
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
OMRChecker v2.0.0 #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: separate schema verdicts from question verdicts;
…_image_shape feat: complete marked bubbles on colored images
… conditional summary/score string
fix: debugging help fix: threshold hack
…es for timelines and dots
fix: py version fix: env class fix: ut issues fix: timezone issue fix: timezone issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes multiple feature requests/issues: #156 #128 #125 #105 #39 #185 #247
Changelogs from #237
Changelogs from #186
Changelogs from #192
Fixes #190 and #191
Also addresses: #36
Other Features covered
feat: template roi gui; created local scripts folder as todo; add new template for conditional sets
fix: defaultSelector issue
feat: support for customFieldTypes in template.json; fix template matching issue
Added support for show_preprocessor_diff{} to display per-processor level before-after images (apart from show_image_level)
Stabilised autorotate by giving option to crop from preview
preview can be enabled for all preprocessors in config.json (autorotating sample is available in Autorotating folder in samples)
Changelogs from #197
Current Master branch:
~35 Files, 4441 loc == Avg 126.8 lines per file, yet highly coupled code and restricted to bubble fields.
After code merge
~112 Files, 16000 loc == Avg 142.8 lines per file, Yet much more readable, more extensible and full of features.