FLOW 41 - add banner #197
Open
FLOW 41 - add banner #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhances announcement banner with bold text, unique IDs, and dismiss persistence using localStorage. Updates banner styles and integrates new props for flexibility. Removes unused routes and theme imports for announcements to simplify code. Improves course filtering logic by adding seat availability checks and refactoring conditions for better readability and maintainability.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an announcement banner to the application. Key changes include:
- Adding new announcement color constants in the global theme.
- Creating a new AnnouncementBanner component along with its styling and animations.
- Inserting the AnnouncementBanner into App.tsx for display.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/constants/GlobalTheme.tsx | Added new color constants for announcement banners |
| src/components/banner/styles/AnnouncementBanner.tsx | Added styled components for the banner with animation rules |
| src/components/banner/AnnouncementBanner.tsx | Implemented the announcement banner component with dismiss logic |
| src/App.tsx | Integrated the AnnouncementBanner into the main app layout |
edwinzhng
reviewed
Apr 28, 2025
src/constants/GlobalTheme.tsx
Outdated
| @@ -30,6 +30,10 @@ export default { | |||
| google: '#4285f4', | |||
| facebook: '#3c5a99', | |||
|
|
|||
| announcement: '#ffc400', | |||
There was a problem hiding this comment.
Can we just use accent instead
There was a problem hiding this comment.
good catch, im stupid lol
edwinzhng
reviewed
Apr 28, 2025
src/constants/GlobalTheme.tsx
Outdated
Comment on lines
34
to
35
| announcementSuccess: '#36b37e', | ||
| announcementWarning: '#ff5630', |
There was a problem hiding this comment.
let's not support these for now since they're not used yet, I think we should probably only use blue/yellow for banners and keep the prof/course colors reserved
Refactors AnnouncementBanner by removing unused 'type' prop and associated styling logic. Replaces dynamic styles with theme-based defaults for consistency. Adjusts margins and link styling for improved layout. Enhances maintainability by streamlining code and eliminating redundant configurations.
|
While editing it, I change the banner to look more minimal. I'm thinking we fix professor reviews before this gets merged in so hopefully we don't need to specify it.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a banner. Probably woefully overengineered.