Naive config reload support #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iBug
reviewed
Sep 2, 2024
|
@iBug This is how I intended to use the reload feature with Kubernetes (by updating a For bare-metal deployment, I believe we need a dedicated "daemon" program that handles a background process, in that way we can reload configs on-demand (eg. like NGINX). |
|
Perhaps your use case is better covered by a separate CLI tool that monitors the file and sends signals. Doing this from within the server program itself seems weird to me. Remember this is server config, not applicatio data. |
|
I would say it looks like a very common pattern in the K8s world, eg. in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1