Remove Duplication of QA Data on Eval and Submit Screens[#6792] #762
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
QA data associated with locations that have been in more than one monitoring plan are now appearing multiple times on the eval and submit screens.
The views that return QA data for the eval and submit screens include a
mon_plan_id
column, which results in multiple records being returned when a location is in the workspace associated with multiple monitoring plans.Background:
This behavior is new after the implementation of the configuration management changes, which introduced functionality that loads all historical monitoring plans into the workspace.
Prior to these changes, only active monitoring plans were loaded into the workspace, so there would only ever be one row for each QA record returned by the views that return QA data for the eval and submit screens.
Changes needed:
Determine if the
mon_plan_id
column is needed as a column in the views that return QA data for the eval and submit screensif not:
remove the
mon_plan_id
column and update the views that return QA data to return a unique list of QA records (wihtoutmon_plan_id
in the view)if so:
update the logic used in the UI to display the QA data to only show a unique list of QA records (while maintaining the
mon_plan_id
for its other identified purpose(s))Update the sorting for the data returned by the views that return QA data for the eval and submit screens
Test Summary - oris, location (unit,stack), system/component id, test type, test number, year/qtr, end date/time
QCE - oris, location (unit/stack), system/component id, event code, event date/time
TEE - oris, location (unit/stack), system/component id, year/qtr
Changes Made:
cert-event-review-and-submit.service.ts
,tee-review-and-submit.service.ts
,test-summary-review-and-submit.service.ts
monPlanBeginMap
minimizes database queries for plan begin datesTesting:
mon_plan_id
filtering preserved for access control