Skip to content

news card complete redesign #2137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 26, 2025
Merged

news card complete redesign #2137

merged 6 commits into from
Mar 26, 2025

Conversation

NeuraByte-UCSD-ITS
Copy link
Contributor

Summary

  • Added horizontal padding for dividers
  • Moved image to the left with fixed width
  • Updated button styling (ActionButton)

Changelog

General Change - news card complete redesign

Test Plan

  • Tested on iOS Simulator and iPhone device
  • Verified no overflow or UI misalignment

c3bryant
c3bryant requested changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@c3bryant c3bryant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting a few changes:

  1. News List Item - Title (not including date) apply blue text theme (style: Theme.of(context).textTheme.headlineMedium)
  2. News List Item - Title and Description - Set height (for line height) to 1.42
  3. News Detail - Revisit

@c3bryant c3bryant merged commit 4948c41 into campus-activation-redesign Mar 26, 2025
0 of 2 checks passed
@c3bryant c3bryant deleted the news-card-redesign branch March 26, 2025 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c3bryant c3bryant c3bryant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NeuraByte-UCSD-ITS @c3bryant