Skip to content

Remove value from parameter nodes #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 15, 2025
Merged

Remove value from parameter nodes #78

merged 8 commits into from
Aug 15, 2025

Conversation

mscroggs
Copy link
Collaborator

@mscroggs mscroggs commented Aug 14, 2025 •
edited
Loading

  • Removes value from ParameterNode: resolves Remove value from ParameterNode #72
  • Removes set_parameters from Graph
  • Adds parameter_values input to functions where it will now be needed
  • Adds PLR0913 (Function has too many arguments) to skips (See Ruff exclusions #19)
  • Make tests in test_causal_problem use same graph fixture as other tests

@mscroggs mscroggs requested a review from willGraham01 August 14, 2025 13:46
willGraham01
willGraham01 approved these changes Aug 15, 2025
View reviewed changes
@mscroggs mscroggs enabled auto-merge (squash) August 15, 2025 10:22
@mscroggs mscroggs merged commit 3390438 into main Aug 15, 2025
5 checks passed
@mscroggs mscroggs deleted the mscroggs/remove-value branch August 15, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willGraham01 willGraham01 willGraham01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove value from ParameterNode
2 participants
@mscroggs @willGraham01