add parameter node #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscroggs
commented
Apr 29, 2025
mscroggs
commented
Apr 29, 2025
mscroggs
commented
Apr 29, 2025
mscroggs
commented
Apr 29, 2025
Merged
willGraham01
approved these changes
May 1, 2025
| if self.value is None: | ||
| msg = "Cannot sample an undetermined parameter node." | ||
| raise ValueError(msg) | ||
| return np.full(samples, self.value) |
There was a problem hiding this comment.
Do we want to return a jax.numpy.full here? I guess right now it's OK as a numpy return since that's what our other algorithms are returning too, but we should probably move to using jax.numpy everywhere for future proofing.
There was a problem hiding this comment.
Yes, we should open an issue for this I think. Currently, we have numpy arrays as return types which will need updating in a few places
Co-authored-by: Will Graham <[email protected]>
Co-authored-by: Will Graham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #36