Skip to content

Add convenience classes for the (multivariate) normal. #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Mar 13, 2025
Merged

Add convenience classes for the (multivariate) normal. #15

merged 31 commits into from
Mar 13, 2025

Conversation

willGraham01
Copy link
Collaborator

@willGraham01 willGraham01 commented Mar 13, 2025 •
edited
Loading

Adds Distribution and DistributionFamily subclasses for the (multivariate) normal distribution.

This is primarily for

  • Us as developers to have some particular classes to experiment with.
  • To provide some convenience classes to users for standard distributions.

Note that we are using jax.random for these implementation, so we are implicitly going with Jax as our default backend.

@willGraham01
Ignore the .vscode folder before I inevitably commit it at least once
fd205ef
@willGraham01
Skeleton base class for distributions
449d597
@willGraham01
Base class for distribution families
f69e4f5
@willGraham01
Distributions sample method is backend-agnostic
91af7b7
@willGraham01
Fix return type of sample method
2a57d56
@willGraham01
Immutable type for storing backend-compatibility info
bdd7be3
@willGraham01
Remove distributon family for now
2842c89
@willGraham01
Clean up imports and typevars
1327588
@willGraham01
Basic docstrings
e67d4b8
@willGraham01
Give useful information in docstrings
2cc3451
@willGraham01
Write tests for SampleCompatibility class
2a7adf7
@willGraham01
Write test for Distribution
db9a3ff
@willGraham01
tests now require multiple backends
609dfd8
@willGraham01
Create a Translator class as you're going to need to do this a lot, Will
e3fb4d5
@willGraham01
Fix the tests that I broke
2cdb0f2
@willGraham01
Add some more detailed docstrings
d8ffaae
@willGraham01
Test the translation method of translators
9c69264
@willGraham01
Fix docstring linting issues
46ac6e8
@willGraham01
Module name to singular to be consistent with #5
b74a477
@willGraham01
Skeleton for distribution family
ccc343a
@willGraham01
Add test for distribution family builder method
f513896
@willGraham01
Expose getter method for Distribution backends
03d3845
@willGraham01
Translator is optional
7ceb2e0
@willGraham01
Merge branch 'main' into wgraham/distribution-family
b5133b3
@willGraham01
Fix docstring
8383d54
@willGraham01
Add note about how distribution families are created
c7af397
@willGraham01
Add jax to explicit package dependencies
9469d1a
@willGraham01
Add normal distribution as a standard distribution
0137dfd
@willGraham01
Create multivariate normal family, that can be attached to a Node
bb01b6a
@willGraham01
Update DistFam docstring to better highlight the purpose of a family
0b219ed
@willGraham01 willGraham01 marked this pull request as ready for review March 13, 2025 12:00
@willGraham01 willGraham01 merged commit e30cae5 into main Mar 13, 2025
5 checks passed
@willGraham01 willGraham01 deleted the wgraham/sample-normal-dists branch March 13, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mscroggs mscroggs mscroggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willGraham01 @mscroggs