-
Notifications
You must be signed in to change notification settings - Fork 134
feat(TU-33149): Move to a new semantic release configuration file structure #723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
TypeScript adoptionCurrent adoption level: 95.9% |
35d45b7 to
7017bea
Compare
|
🥷 Code experts: tf-security tf-security has most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame: ✨ Comment |
|
The CI Standard Checks workflow is failing because I am adding I tried adding them to I am going to bypass this check given it's a one-time setup and it will only fail again if these files are changed. |
|
[BOT] Preview available with hash |
|
|
@joycevherck Would you mind approving again? & Are you comfortable with me bypassing the failure? |
# [@typeform/embed-v5.8.0](https://github.com/Typeform/embed/compare/@typeform/embed-v5.7.0...@typeform/embed-v5.8.0) (2025-12-12) ### Features * **TU-33149:** Move to a new semantic release configuration file structure ([#723](#723)) ([9d782f7](9d782f7))
# [@typeform/embed-react-v4.9.0](https://github.com/Typeform/embed/compare/@typeform/embed-react-v4.8.0...@typeform/embed-react-v4.9.0) (2025-12-12) ### Features * **TU-33149:** Move to a new semantic release configuration file structure ([#723](#723)) ([9d782f7](9d782f7))
|
🎉 This PR is included in version @typeform/embed-react-v4.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |



Current problems
After playing around with the dry-run functionality of
semantic-releaselocally I found:semantic-releaseruns from each package directory (e.g., packages/embed/), not from the repo root.package.jsonit finds, so it never reached the root.releaserc. This is not an issue in single-package repos where the config lives alongside the only package.json.extends: ["semantic-release-monorepo"]was moved from.releasercto a-ecommand line flag. This change assumed the root config would still be found, but due to the monorepo structure, it wasn't.semantic-releaseused its default config, main wasn't the first branch in the list (maintenance patterns and master come first). This meant:Channeldefaulted to the branch name (main) instead ofnullmain: falsewas set (only the first branch in the list getsmain: true)Changes
release.config.base.js) with:extends: ['semantic-release-monorepo']includedrelease.config.jsthat imports the shared config, ensuring cosmiconfig finds it immediately when running from that package's directory.-eflag from package scripts sinceextends...is now in the base config file.