-
-
Notifications
You must be signed in to change notification settings - Fork 623
docs: Update exporter examples #1989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
I'm not sure about this part of the change:
It demos well and shows the output immediately which is very useful for comparison, I'd prefer to keep it as it was. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that I get the motivation behind this change?
Sorry to do this to you again, but why is this not just the side-by-side diff? I feel like I'm missing why the change was made. |
If you look at the website currently, there's not really enough space to do a side-by-side view properly in the demos. We could make them stacked vertically instead (the editor and email/pdf view) but again it's not great because of the limited space. So I think having a toggle makes the most sense. Ofc for the playground, side-by-side would be better as we have almost the whole viewport to work with. |
Ok, yea I get what you mean, I just worry about the discovery of it... Is there an in-between here, where if we have the space it does a side-by-side? I'm not sure what the best thing to do is here. |
Hmm I think maybe if we switch between vertically stacked and side-by-side depending on available space that could work |
@nperez0111 I ended up doing the suggestion from my previous comment, and ended up overhauling the styling for all import/export examples since they were ugly as all hell. The stacked view is still really cramped for the PDF and email demos in the docs section, but everything looks a lot better now in the examples section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Good fix to have
This PR unifies and cleans up the code across the export/import examples, and overhauls the styling so that each of them have a clean & matching look.