Fixed importing sqlite3#verbose using destructuring syntax
#1632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sqlite3#verbose now returns sqlite3 instead of globalThis object when
bound to undefined (void 0). This enables importing verbose in
typescript using `import { verbose as sqlite3 } from "sqlite3"`. Because
typescript automatically converts import statement to
`sqlite3_1.default.verbose();`.
daniellockyer
changed the title
sqlite3#verbose using destructuring syntax
Contributor
|
Thank you! 🙂 |
1 task
This was referenced Sep 13, 2024
This was referenced Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sqlite3#verbose now returns sqlite3 instead of globalThis object when
bound to undefined (void 0). This enables importing verbose in
typescript using
import { verbose as sqlite3 } from "sqlite3". Becausetypescript automatically converts import statement to
sqlite3_1.default.verbose();.