Skip to content

Reverted empty-strings db migration #10430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2019
Merged

Reverted empty-strings db migration #10430

merged 1 commit into from
Jan 29, 2019

Conversation

allouis
Copy link
Contributor

@allouis allouis commented Jan 29, 2019 •
edited by kevinansfield
Loading

no issue

  • revert the migration because migrations that (potentially) touch every row should be kept to major releases where possible
    • the migration was safe to run and won't cause any problems for anyone who has already upgraded
  • reversion keeps the migration file but changes the contents to a no-op so that migrations table state is the same for all users whether they migrated with the full migration or the no-op version

@kevinansfield kevinansfield merged commit e9c3040 into TryGhost:master Jan 29, 2019
@allouis allouis deleted the revert-migration branch January 29, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allouis @kevinansfield