Improve typing and documentation of AdversarialPatchPyTorch #2557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… detection Signed-off-by: Beat Buesser <[email protected]>
Signed-off-by: Beat Buesser <[email protected]>
beat-buesser
added
documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev_1.19.1 #2557 +/- ##
==============================================
- Coverage 85.41% 85.41% -0.01%
==============================================
Files 334 334
Lines 31001 31002 +1
Branches 5300 5300
==============================================
Hits 26481 26481
Misses 3053 3053
- Partials 1467 1468 +1
|
Signed-off-by: Beat Buesser <[email protected]>
kieranfraser
approved these changes
Jan 17, 2025
Collaborator
kieranfraser
left a comment
kieranfraser
left a comment
There was a problem hiding this comment.
LGTM - added one minor suggestion. There is a few legacy tests failing, and codecov not at required mark (but clicking through I noted that not due to this PR changes).
| :param x: An array with the original input images of shape NCHW or input videos of shape NFCHW. | ||
| :param y: An array with the original true labels. | ||
| :param y: The true or target labels. |
Collaborator
There was a problem hiding this comment.
A minor suggestion to include format of expected data in the dict (e.g. boxes, scores, labels)? Torchvision models conform to this format, but users who may be more familiar with YOLO may feed targets here that are not in the correct format?
Collaborator
Author
There was a problem hiding this comment.
@kieranfraser Thank you, that's a good point!
Signed-off-by: Beat Buesser <[email protected]>
Signed-off-by: Beat Buesser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request improves the typing and documentation of the
AdversarialPatchPyTorchattack.