Skip to content

docs(app): Improve load model docs page #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 26, 2024

Conversation

JaimeTorrealba
Copy link
Member

No description provided.

@JaimeTorrealba JaimeTorrealba self-assigned this Jan 10, 2024
Copy link

netlify bot commented Jan 10, 2024

Deploy Preview for tresjs-docs ready!

Name Link
🔨 Latest commit 467e1ec
🔍 Latest deploy log https://app.netlify.com/sites/tresjs-docs/deploys/65b3b73e90f3bc0008121681
😎 Deploy Preview https://deploy-preview-505--tresjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@alvarosabu alvarosabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-01-12 at 16 51 14

Now that the suspense is gone, the highlighted lines are incorrect in most of the doc, could you fix them please?

Comment on lines +13 to +16
::: warning
Please note that the examples above we use top level await, make sure you wrap it with a [Suspense](https://vuejs.org/guide/built-ins/suspense.html#suspense) component. See Suspense for more information. .
:::

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏻 @JaimeTorrealba

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@JaimeTorrealba
Copy link
Member Author

@alvarosabu this is also ready, please let me know

@alvarosabu alvarosabu merged commit ae75643 into main Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants