refactor!: context camera is now a state #1004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: camera ctx property is now an object with the camera manager instead of the active camera
alvarosabu
added
p3-significant
…te-instead-of-spreading-it
commit: |
Tinoooo
requested changes
Apr 28, 2025
Co-authored-by: Tino Koch <[email protected]>
Co-authored-by: Tino Koch <[email protected]>
Co-authored-by: Tino Koch <[email protected]>
4 tasks
- Replaced instances of TresCamera with Three.js Camera type across the codebase for better compatibility and consistency. - Updated camera management logic in useCamera composable and related components to reflect the new type. - Simplified currentCamera logic to use computed properties instead of watch.
- Updated the orthographic camera initialization to correctly calculate frustum dimensions based on the aspect ratio. - Introduced zoom functionality for the orthographic camera. - Simplified the useControls setup by removing unnecessary properties and focusing on essential controls. - Adjusted the camera update logic to reflect the new control structure, ensuring proper projection matrix updates.
Tinoooo
reviewed
May 12, 2025
…nents - Removed manual camera initialization in favor of using TresJS components for perspective and orthographic cameras. - Updated the template to conditionally render the appropriate camera based on the selected camera type. - Enhanced readability and maintainability by leveraging TresJS's built-in camera properties and methods.
- Eliminated unused imports for OrthographicCamera and PerspectiveCamera from Three.js to streamline the code. - This change enhances code clarity and reduces unnecessary dependencies, aligning with the recent updates to utilize TresJS components for camera management.
Tinoooo
approved these changes
May 15, 2025
alvarosabu
deleted the
chore/985-add-usecamera-return-object-to-state-instead-of-spreading-it
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: camera ctx property is now an object with the camera manager instead of the active camera
Closes #985