Skip to content

refactor!: removal of performance state from useTresContextProvider #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Tinoooo
Copy link
Member

@Tinoooo Tinoooo commented Apr 24, 2025

No description provided.

Tinoooo added 5 commits April 23, 2025 12:33
… context

BREAKING CHANGE:

- useTresReady is no longer available, it has been replaced by isReady in the renderer in the context
- onTresReady is no longer available. renderer.isReady should be leveraged instead
@Tinoooo Tinoooo self-assigned this Apr 24, 2025
@Tinoooo Tinoooo requested a review from alvarosabu as a code owner April 24, 2025 10:42
@Tinoooo Tinoooo linked an issue Apr 24, 2025 that may be closed by this pull request
4 tasks
@Tinoooo Tinoooo changed the base branch from main to next April 24, 2025 10:42
Copy link

netlify bot commented Apr 24, 2025

Deploy Preview for tresjs-docs ready!

Name Link
🔨 Latest commit a693d34
🔍 Latest deploy log https://app.netlify.com/sites/tresjs-docs/deploys/680a15aa75c637000855c748
😎 Deploy Preview https://deploy-preview-1003--tresjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Tinoooo
Copy link
Member Author

Tinoooo commented Apr 24, 2025

requires #1000 to be merged first

@alvarosabu
Copy link
Member

Hi, @Tinoooo can you please merge the latest next to do the review? Thanks

…formance-state-out-of-usetrescontextprovider
@Tinoooo
Copy link
Member Author

Tinoooo commented Apr 28, 2025

Hi, @Tinoooo can you please merge the latest next to do the review? Thanks

Yes. Done ✅

Copy link

pkg-pr-new bot commented Apr 28, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@tresjs/core@1003

commit: 2312e42

@alvarosabu alvarosabu merged commit 79edf43 into next May 28, 2025
4 checks passed
@alvarosabu alvarosabu deleted the feature/1001-move-performance-state-out-of-usetrescontextprovider branch May 28, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move performance state out of useTresContextProvider
2 participants