Skip to content

fix: create a local raycast for the HTML component #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alvarosabu
Copy link
Member

No description provided.

@alvarosabu alvarosabu requested a review from Copilot June 30, 2025 09:59
@alvarosabu alvarosabu self-assigned this Jun 30, 2025
@alvarosabu alvarosabu added bug Something isn't working p4-important-bug Violate documented behavior or significantly improve performance (priority) v5 labels Jun 30, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a local Raycaster instance for the HTML component and streamlines demo pages by inlining TresCanvas props and updating GLTF usage.

  • HTML.vue: remove global raycaster, add local Raycaster ref and clean up imports
  • LaptopDemo.vue: switch to composable useGLTF (no await), remove gl config object, add a computed for the Macbook node
  • HTMLDemo.vue: remove gl config object, inline TresCanvas props (clear-color, shadows)

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/core/misc/html/HTML.vue Introduce local Raycaster, remove context-provided one
playground/vue/src/pages/misc/LaptopDemo.vue Refactor GLTF loading, inline canvas props, compute model
playground/vue/src/pages/misc/HTMLDemo.vue Inline canvas props, remove unused GL config object
Comments suppressed due to low confidence (1)

playground/vue/src/pages/misc/LaptopDemo.vue:8

  • The computed helper is used here but not imported from 'vue'. Please add import { computed } from 'vue' at the top of the script.
const laptop = computed(() => nodes.value.Macbook)

@alvarosabu alvarosabu linked an issue Jun 30, 2025 that may be closed by this pull request
5 tasks
@alvarosabu alvarosabu merged commit 614505f into next Jun 30, 2025
4 checks passed
@alvarosabu alvarosabu deleted the bugfix/626-cientos-v5-html-with-model-integration-is-broken branch June 30, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p4-important-bug Violate documented behavior or significantly improve performance (priority) v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cientos v5, html with model integration is broken
1 participant