Skip to content

Conversation

0oshowero0
Copy link
Collaborator

What does this PR do?

Add concise overview of what this PR aims to achieve or accomplish. Reference related GitHub issues and PRs that help with the review.

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

@0oshowero0 0oshowero0 merged commit e94019f into main Sep 25, 2025
@0oshowero0 0oshowero0 deleted the main_hzy branch September 25, 2025 07:44
0oshowero0 added a commit that referenced this pull request Sep 28, 2025
* update client docstring

Signed-off-by: 0oshowero0 <[email protected]>

* fix n_sample related problems

Signed-off-by: 0oshowero0 <[email protected]>

---------

Signed-off-by: 0oshowero0 <[email protected]>
ji-huazhong pushed a commit to ji-huazhong/verl that referenced this pull request Oct 13, 2025
* update client docstring

Signed-off-by: 0oshowero0 <[email protected]>

* fix n_sample related problems

Signed-off-by: 0oshowero0 <[email protected]>

---------

Signed-off-by: 0oshowero0 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant