- 
                Notifications
    You must be signed in to change notification settings 
- Fork 101
[Nu-8656] Abstract FlinkEngineRuntimeContext #8663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            DeamonDev
  wants to merge
  6
  commits into
  staging
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
nu-8656-adjust-flink-custom-node-ctx-to-flink-2.0
  
      
      
   
  
    
  
  
  
 
  
      
    base: staging
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Open
            
            [Nu-8656] Abstract FlinkEngineRuntimeContext #8663
                    DeamonDev
  wants to merge
  6
  commits into
  staging
from
nu-8656-adjust-flink-custom-node-ctx-to-flink-2.0
  
      
      
   
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    e0cd84a    to
    606f225      
    Compare
  
    606f225    to
    66e1ea1      
    Compare
  
    
              
                    arkadius
  
              
              reviewed
              
                  
                    Oct 7, 2025 
                  
              
              
            
            
        
          
                .../components-api/src/main/scala/pl/touk/nussknacker/engine/flink/api/FlinkEngineContext.scala
              
                Outdated
          
            Show resolved
            Hide resolved
        
      66e1ea1    to
    b527ee5      
    Compare
  
    
              
                    arkadius
  
              
              reviewed
              
                  
                    Oct 7, 2025 
                  
              
              
            
            
        
          
                ...utor/src/main/scala/pl/touk/nussknacker/engine/process/registrar/FlinkProcessRegistrar.scala
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                ...in/scala/pl/touk/nussknacker/engine/flink/api/exception/SinkWriterWithExceptionHandler.scala
          
            Show resolved
            Hide resolved
        
      ab506a3    to
    33a5428      
    Compare
  
    7e8520d    to
    c0a4121      
    Compare
  
    
              
                    arkadius
  
              
              reviewed
              
                  
                    Oct 8, 2025 
                  
              
              
            
            
        
          
                .../scala/pl/touk/nussknacker/engine/process/exception/SinkWriterWithExceptionHandlerTest.scala
              
                Outdated
          
            Show resolved
            Hide resolved
        
      | created: #8672 | 
              
                    arkadius
  
              
              reviewed
              
                  
                    Oct 8, 2025 
                  
              
              
            
            
        
          
                ...t/scala/pl/touk/nussknacker/engine/flink/table/sink/SinkWriterWithExceptionHandlerTest.scala
              
                Outdated
          
            Show resolved
            Hide resolved
        
      576ecf6    to
    8a7b920      
    Compare
  
    1c9a809    to
    339009f      
    Compare
  
    3505087    to
    6581e35      
    Compare
  
    
              
                    arkadius
  
              
              reviewed
              
                  
                    Oct 10, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 It looks good. Let's wait until all the paperwork is completed and then we can merge it.
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Describe your changes
In this PR I add wrapper for
RuntimeContextto supportWriterInitContextfrom new Flink's API. See #8656 for context.Thanks for @piotrp for suggesting me the shape of
SinkWriterWithExceptionHandlerand general idea of wrapping this context.Checklist before merge