Skip to content

Conversation

@DeamonDev
Copy link
Contributor

@DeamonDev DeamonDev commented Oct 3, 2025

Describe your changes

In this PR I add wrapper for RuntimeContext to support WriterInitContext from new Flink's API. See #8656 for context.

Thanks for @piotrp for suggesting me the shape of SinkWriterWithExceptionHandler and general idea of wrapping this context.

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@DeamonDev DeamonDev self-assigned this Oct 3, 2025
@DeamonDev DeamonDev force-pushed the nu-8656-adjust-flink-custom-node-ctx-to-flink-2.0 branch from e0cd84a to 606f225 Compare October 6, 2025 07:30
@DeamonDev DeamonDev marked this pull request as ready for review October 6, 2025 08:37
@DeamonDev DeamonDev requested a review from arkadius October 6, 2025 08:37
@DeamonDev DeamonDev force-pushed the nu-8656-adjust-flink-custom-node-ctx-to-flink-2.0 branch from 606f225 to 66e1ea1 Compare October 7, 2025 08:52
@DeamonDev DeamonDev force-pushed the nu-8656-adjust-flink-custom-node-ctx-to-flink-2.0 branch from 66e1ea1 to b527ee5 Compare October 7, 2025 09:55
@DeamonDev DeamonDev force-pushed the nu-8656-adjust-flink-custom-node-ctx-to-flink-2.0 branch from ab506a3 to 33a5428 Compare October 7, 2025 17:36
@DeamonDev DeamonDev requested a review from arkadius October 8, 2025 08:07
@DeamonDev DeamonDev force-pushed the nu-8656-adjust-flink-custom-node-ctx-to-flink-2.0 branch from 7e8520d to c0a4121 Compare October 8, 2025 10:51
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

created: #8672
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

@DeamonDev DeamonDev requested a review from arkadius October 8, 2025 14:30
@DeamonDev DeamonDev force-pushed the nu-8656-adjust-flink-custom-node-ctx-to-flink-2.0 branch from 576ecf6 to 8a7b920 Compare October 9, 2025 11:52
@DeamonDev DeamonDev requested a review from arkadius October 9, 2025 11:52
@DeamonDev DeamonDev force-pushed the nu-8656-adjust-flink-custom-node-ctx-to-flink-2.0 branch from 1c9a809 to 339009f Compare October 9, 2025 19:51
@DeamonDev DeamonDev force-pushed the nu-8656-adjust-flink-custom-node-ctx-to-flink-2.0 branch from 3505087 to 6581e35 Compare October 10, 2025 09:12
Copy link
Member

@arkadius arkadius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 It looks good. Let's wait until all the paperwork is completed and then we can merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adapt exception handler preparation in FlinkCustomNodeContext for Flink 2.0

3 participants