Skip to content

CI: fix conda upload #2198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2025
Merged

CI: fix conda upload #2198

merged 1 commit into from
Aug 5, 2025

Conversation

casperdcl
Copy link
Member

@casperdcl casperdcl commented Aug 5, 2025

- Fix failing CI due to redundant numpy builds no longer needed after #2156.
- Lightweight alternative to #2196
@casperdcl casperdcl requested a review from a team as a code owner August 5, 2025 14:39
@casperdcl casperdcl self-assigned this Aug 5, 2025
@casperdcl casperdcl requested a review from gfardell August 5, 2025 14:39
@github-project-automation github-project-automation bot moved this to Todo in CIL work Aug 5, 2025
@casperdcl casperdcl added this to the v25.0.0 milestone Aug 5, 2025
@casperdcl casperdcl moved this from Todo to Priority review in CIL work Aug 5, 2025
conda mambabuild . -c conda-forge -c https://tomography.stfc.ac.uk/conda --override-channels --python=${{ matrix.python-version }} --numpy=${{ matrix.numpy-version }} --output-folder .
- uses: actions/upload-artifact@v4
with:
name: cil-package-py${{ matrix.python-version }}-np${{ matrix.numpy-version }}
path: recipe/linux-64/cil*
- name: anaconda upload -c ccpi
if: github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/tags')
if: >
(github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/tags')) && matrix.numpy-version == '1.26'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TL;DR: numpy==1.26 always corresponds to just one matrix.python-version so there's no conflicts

Copy link
Member

@gfardell gfardell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good hack!

@casperdcl casperdcl merged commit 324b803 into master Aug 5, 2025
10 checks passed
@casperdcl casperdcl deleted the fix-conda-upload branch August 5, 2025 22:39
@github-project-automation github-project-automation bot moved this from Priority review to Done in CIL work Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants