Skip to content

Fixed:weighted majority vote example:use instance rather than class #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2023
Merged

Fixed:weighted majority vote example:use instance rather than class #81

merged 1 commit into from
Sep 29, 2023

Conversation

@shenxiangzhuang
Copy link
Contributor

@shenxiangzhuang shenxiangzhuang commented Sep 4, 2023 •
edited by dustalov
Loading

Checklist

  • I have read the CONTRIBUTING document
  • I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@shenxiangzhuang
Copy link
Contributor Author

shenxiangzhuang commented Sep 4, 2023

I think the documentation should be generated by docstring here? But I think keep the related task undone is better to make it clear.

dustalov
dustalov approved these changes Sep 4, 2023
View reviewed changes
Copy link
Collaborator

@dustalov dustalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the documentation is generated separately.

@dustalov
Copy link
Collaborator

dustalov commented Sep 4, 2023

We will merge it after we fix #80.

@pilot7747 pilot7747 merged commit 3b3f5d9 into Toloka:main Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dustalov dustalov dustalov approved these changes

@pilot7747 pilot7747 Awaiting requested review from pilot7747 pilot7747 is a code owner

@aliskin aliskin Awaiting requested review from aliskin aliskin is a code owner

@denaxen denaxen Awaiting requested review from denaxen denaxen is a code owner

@varfolomeii varfolomeii Awaiting requested review from varfolomeii varfolomeii is a code owner

@alexdrydew alexdrydew Awaiting requested review from alexdrydew alexdrydew is a code owner

@Pocoder Pocoder Awaiting requested review from Pocoder Pocoder is a code owner

@vlad-mois vlad-mois Awaiting requested review from vlad-mois vlad-mois is a code owner

@DrhF DrhF Awaiting requested review from DrhF DrhF is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shenxiangzhuang @dustalov @pilot7747