Skip to content

Add .size() to allow for parsing NDJSON files. #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 41_fixes
Choose a base branch
from
Open

Add .size() to allow for parsing NDJSON files. #21

wants to merge 1 commit into from

Conversation

dsully
Copy link

@dsully dsully commented Jul 8, 2025

Fixes #20

@TkTech
Copy link
Owner

TkTech commented Jul 9, 2025 •
edited
Loading

Nice! I wonder if size() is the right name here - I might expect size() to be the actual size of the parsed document. Maybe an explicit bytes_read()?

@TkTech TkTech changed the base branch from main to 41_fixes July 9, 2025 14:54
@TkTech TkTech added the enhancement New feature or request label Jul 9, 2025
@dsully
Copy link
Author

dsully commented Jul 11, 2025

Sounds good. I'll make that change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose yyjson_doc_get_read_size?
2 participants
@dsully @TkTech