Skip to content

Conversation

@skourta
Copy link
Collaborator

@skourta skourta commented Apr 3, 2025

This pull request introduces several changes to improve error handling, type annotations, and code readability in the tiralib/tiramisu module. The most important changes include the addition of a custom exception, enhancements to type annotations, and improvements to assertion formatting.

Error handling improvements:

Type annotations:

Code readability:

Dependency imports:

@skourta skourta requested review from Mascinissa and Copilot April 3, 2025 05:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves error handling in the tiramisu module by introducing a custom ServerExecutionFailedError, enhancing type annotations, and reformatting assertions for better readability.

  • Introduces a new ServerExecutionFailedError exception in function_server.py.
  • Uses enhanced type annotations in function_server.py’s init.
  • Reformats assertions in function_server.py and raises the new error in schedule.py.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
tiralib/tiramisu/schedule.py Adds a new error raise using ServerExecutionFailedError and updates the import statements.
tiralib/tiramisu/function_server.py Introduces ServerExecutionFailedError, enhances type annotations in init, and reformats an assertion in the run method.

Copy link
Collaborator

@Mascinissa Mascinissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@skourta skourta merged commit 3289668 into main Apr 3, 2025
3 checks passed
@skourta skourta deleted the success-check-for-server branch April 3, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants