Skip to content

Conversation

@skourta
Copy link
Collaborator

@skourta skourta commented Mar 19, 2025

This pull request to tiralib/tiramisu/tiramisu_tree.py includes changes to improve the handling of upper bounds and adds new methods for generating ISL AST strings. The most important changes include modifying the upper bound calculation and adding methods to generate ISL AST string representations of the tiramisu tree.

Improvements to upper bound handling:

  • Modified the from_isl_ast_string_list method to add 1 to the upper bound when converting it to an integer to account for the ISL's inclusive upper bound.

Enhancements to ISL AST string generation:

  • Added a new method get_isl_ast_string to generate the ISL AST string representation of the tiramisu tree.
  • Added a helper method _get_isl_ast_string_of_node to recursively generate the ISL AST string for each node in the tiramisu tree.

@skourta skourta requested a review from Mascinissa March 19, 2025 05:18
Copy link
Collaborator

@Mascinissa Mascinissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@skourta skourta merged commit 5403dc8 into main Mar 19, 2025
3 checks passed
@skourta skourta deleted the isl-ast branch March 19, 2025 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants