Fix google-cloud-cpp build failures on CMake 3.30.
#5167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teo-tsirpanis
force-pushed
the
teo/gcs-sdk-patch
branch
from
e493db0 to
b85bdfe
Compare
Member
Author
|
No GCS CI jobs happened to use CMake 3.30, but I have validated it locally. |
KiterLuc
approved these changes
Jul 9, 2024
This was referenced Jul 9, 2024
KiterLuc
pushed a commit
that referenced
this pull request
Jul 9, 2024
[SC-50499](https://app.shortcut.com/tiledb-inc/story/50499/ci-s-updating-of-cmake-3-30-broke-building-the-gcs-port) GitHub Action's recent rollout of CMake 3.30 has broken building the `google-cloud-cpp` port, because it cannot find the `GTest::gmock_main` target (which is otherwise unused for the mainstream building scenario). This PR patches the port to remove the `target_link_libraries` command that links to GMock. Subsequent versions of the Google Cloud client library have added an official option to disable building the mock libraries, and microsoft/vcpkg#39802 has been opened to specify the option in the upstream port. --- TYPE: NO_HISTORY (cherry picked from commit 4c76857)
KiterLuc
pushed a commit
that referenced
this pull request
Jul 9, 2024
[SC-50499](https://app.shortcut.com/tiledb-inc/story/50499/ci-s-updating-of-cmake-3-30-broke-building-the-gcs-port) GitHub Action's recent rollout of CMake 3.30 has broken building the `google-cloud-cpp` port, because it cannot find the `GTest::gmock_main` target (which is otherwise unused for the mainstream building scenario). This PR patches the port to remove the `target_link_libraries` command that links to GMock. Subsequent versions of the Google Cloud client library have added an official option to disable building the mock libraries, and microsoft/vcpkg#39802 has been opened to specify the option in the upstream port. --- TYPE: NO_HISTORY (cherry picked from commit 4c76857)
KiterLuc
added a commit
that referenced
this pull request
Jul 9, 2024
…e 3.30. (#5167) (#5171) Backport 4c76857 from #5167. --- TYPE: NO_HISTORY Co-authored-by: Theodore Tsirpanis <[email protected]>
KiterLuc
added a commit
that referenced
this pull request
Jul 11, 2024
…e 3.30. (#5167) (#5172) Backport 4c76857 from #5167. --- TYPE: NO_HISTORY Co-authored-by: Theodore Tsirpanis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-50499
GitHub Action's recent rollout of CMake 3.30 has broken building the
google-cloud-cppport, because it cannot find theGTest::gmock_maintarget (which is otherwise unused for the mainstream building scenario).This PR patches the port to remove the
target_link_librariescommand that links to GMock. Subsequent versions of the Google Cloud client library have added an official option to disable building the mock libraries, and microsoft/vcpkg#39802 has been opened to specify the option in the upstream port.TYPE: NO_HISTORY