Add VFS list example, with optional config #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shelnutt2
approved these changes
May 3, 2024
shaunrd0
approved these changes
May 3, 2024
Comment on lines
10
to
14
| private readonly string _array_path; | ||
| private readonly Context _ctx; | ||
| private readonly VFS _vfs; | ||
|
|
||
| public ExampleVFS() |
There was a problem hiding this comment.
I would prefer the class to be static, the fields to be local variables, the constructor to be merged with Run, and CreateFiles and ListFiles to be local functions inside Run.
Feel free to make the adjustments or I will on Wednesday when I return.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add VFS list example, with optional config for usage to set S3 or other parameters.