Update to the .NET 8 SDK and use some new C# features. #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Please review this with whitespace diffs turned off.
Similar to #141, this PR updates the required version of the .NET SDK to .NET 8, and uses some new and less new C# language features along the way. We update the SDK primarily because .NET 7 will go out of support in May 2024, and to enable updating the ClangSharpPInvokeGenerator whose latest version runs on .NET 8.
Like the previous PR, this does not affect the C# API's runtime targeting of .NET 5. .NET 8 will be required only to build it from source.