-
Notifications
You must be signed in to change notification settings - Fork 3
Feat integrate real connector testing #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
} | ||
|
||
dependencies { | ||
implementation(libs.edc.runtime.metamodel) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EDC also provides bom
modules that can be used to keep the dependencies block lean. Please consider using them, maybe in the next PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's already a gradle wrapper in the root folder, maybe we can only keep that one
|
||
public class SeedVaultExtension implements ServiceExtension { | ||
|
||
private static final String PUBLIC_KEY = """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also if only for test is never good to put hardcoded keys.
In the mds-edc
we have a class that can generate a key pair on the fly and encode it to base64, I think it's pretty smart:
https://github.com/Mobility-Data-Space/mds-edc/blob/4a9227ada54c807f7ff6f42778835ffe03a442d5/tests/src/test/java/eu/dataspace/connector/tests/Crypto.java
src/test/java/io/thinkit/edc/client/connector/RealTimeConnectorApiTestBase.java
Outdated
Show resolved
Hide resolved
src/test/java/io/thinkit/edc/client/connector/RealTimeConnectorApiTestBase.java
Outdated
Show resolved
Hide resolved
src/test/java/io/thinkit/edc/client/connector/RealTimeConnectorApiTestBase.java
Outdated
Show resolved
Hide resolved
src/test/java/io/thinkit/edc/client/connector/RealTimeConnectorApiTestBase.java
Outdated
Show resolved
Hide resolved
src/test/java/io/thinkit/edc/client/connector/RealTimeConnectorApiTestBase.java
Outdated
Show resolved
Hide resolved
format.version = "1.1" | ||
|
||
[versions] | ||
edc = "0.11.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's use the latest version: 0.13.0
edc-validator-data-address-http-data = { module = "org.eclipse.edc:validator-data-address-http-data", version.ref = "edc" } | ||
|
||
[plugins] | ||
shadow = { id = "com.github.johnrengelman.shadow", version.ref = "shadow" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the outdated id, now you can use com.gradleup.shadow
version 8.3.6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need this wrapper inside connector
, as there's already a gradle wrapper in the root of the project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same, this can be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
No description provided.