Skip to content

Feat integrate real connector testing #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

chaimaMeliani
Copy link
Contributor

No description provided.

@chaimaMeliani chaimaMeliani requested a review from ndr-brt June 11, 2025 09:06
@chaimaMeliani chaimaMeliani self-assigned this Jun 11, 2025
}

dependencies {
implementation(libs.edc.runtime.metamodel)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDC also provides bom modules that can be used to keep the dependencies block lean. Please consider using them, maybe in the next PR

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's already a gradle wrapper in the root folder, maybe we can only keep that one


public class SeedVaultExtension implements ServiceExtension {

private static final String PUBLIC_KEY = """
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also if only for test is never good to put hardcoded keys.
In the mds-edc we have a class that can generate a key pair on the fly and encode it to base64, I think it's pretty smart:
https://github.com/Mobility-Data-Space/mds-edc/blob/4a9227ada54c807f7ff6f42778835ffe03a442d5/tests/src/test/java/eu/dataspace/connector/tests/Crypto.java

@chaimaMeliani chaimaMeliani requested a review from ndr-brt July 2, 2025 14:02
format.version = "1.1"

[versions]
edc = "0.11.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use the latest version: 0.13.0

edc-validator-data-address-http-data = { module = "org.eclipse.edc:validator-data-address-http-data", version.ref = "edc" }

[plugins]
shadow = { id = "com.github.johnrengelman.shadow", version.ref = "shadow" }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the outdated id, now you can use com.gradleup.shadow version 8.3.6

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need this wrapper inside connector, as there's already a gradle wrapper in the root of the project

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same, this can be removed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants