feat: provide extensibility capabilities #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdionisi
reviewed
Dec 6, 2024
src/main/java/io/thinkit/edc/client/connector/EdcConnectorClient.java
Outdated
Show resolved
Hide resolved
src/main/java/io/thinkit/edc/client/connector/EdcConnectorClient.java
Outdated
Show resolved
Hide resolved
src/test/java/io/thinkit/edc/client/connector/EdcConnectorClientTest.java
Outdated
Show resolved
Hide resolved
ndr-brt
force-pushed
the
174-provide-extensibility
branch
2 times, most recently
from
8030d3d to
e89b2ef
Compare
chaimaMeliani
approved these changes
Dec 13, 2024
ndr-brt
force-pushed
the
174-provide-extensibility
branch
from
e89b2ef to
8036957
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
provides extensibility capabilities to the client, by introducing the
EdcResourceabstract class.By extending it, a constructor that gets a
EdcContextinstance is passed. That one contains all the services that could be useful (http client, object mapper, urls...).Why
It would be useful to cover custom extensions
Notes
I didn't use the "service" term currently used in the package name because I think that's too vague, while "resource" better represent the point of view of a RESTful API.
This PR solves a single task in #174, other PRs will come.
Part of #174
Added @fdionisi as optional reviewer as he already implemented similar functionality in the TS client