Skip to content

Conversation

openroad-ci
Copy link
Collaborator

The envars should exist for generate_abstract stage.
Removing the stages section will allow the envars to apply to all stages.

Signed-off-by: Jaehyun Kim <[email protected]>
@maliberty
Copy link
Member

How do these variables affect abstract generation?

@maliberty
Copy link
Member

nvm, I see it is -hier from you other comments.

@maliberty
Copy link
Member

This change moves them to "Uncategorized variables". @oharboe is it possible to add generate_abstract as a stage?

@maliberty
Copy link
Member

It looks like it is based on erase_non_stage_variables generate_abstract. @jhkim-pii it would be better to add that stage so they remain categorized. It would be nice to have an all stage rather than having to list them out.

@jhkim-pii
Copy link
Contributor

nvm, I see it is -hier from you other comments.

OK. Let me try to add all stage.

Signed-off-by: Jaehyun Kim <[email protected]>
@jhkim-pii
Copy link
Contributor

Done.

@jhkim-pii jhkim-pii requested a review from maliberty September 15, 2025 06:21
@maliberty maliberty enabled auto-merge September 15, 2025 15:35
@maliberty maliberty merged commit 08ca8d2 into The-OpenROAD-Project:master Sep 15, 2025
8 checks passed
@maliberty maliberty deleted the secure-update-variables-yaml branch September 15, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hang occurred during reading SPEF in a generate_abstract stage
3 participants