Return original path #406
Merged
Return original path #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 25, 2018 17:15
|
Thanks for working on this @updateaman - the changes look good so far. Could you additionally check if we have the same inconsistency for |
|
@fgreinacher yes, they had the same problem with ToString(). I've fixed them and added tests |
fgreinacher
suggested changes
Nov 30, 2018
System.IO.Abstractions.TestingHelpers.Tests/MockDriveInfoTests.cs
Outdated
Show resolved
Hide resolved
System.IO.Abstractions.TestingHelpers.Tests/MockFileInfoTests.cs
Outdated
Show resolved
Hide resolved
fgreinacher
approved these changes
Dec 3, 2018
|
LGTM, thanks again @updateaman! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix issue #400
Return original directory path passed by the user from MockDirectoryInfo ToString() method.
Which is what the original directoryInfo class does:
https://github.com/dotnet/corefx/blob/master/src/System.IO.FileSystem/src/System/IO/DirectoryInfo.cs