Fix for #284: MockFile.Delete does not throw exception when file does not exist. #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgreinacher
reviewed
Oct 30, 2018
fgreinacher
reviewed
Oct 30, 2018
| { | ||
| var fileSystem = new MockFileSystem(); | ||
| var path = XFS.Path("C:\\test"); | ||
| var path = XFS.Path("C:\\some_folder\\test"); |
There was a problem hiding this comment.
Why is this change necessary?
There was a problem hiding this comment.
Because of potential bug. Consider this code:
var fileSystem = new MockFileSystem();
var path = XFS.Path("C:\\test.txt");
DirectoryInfoBase dir = fileSystem.Directory.GetParent(path);
It works ok on Windows but throws NullReferenceException on Linux. And after my changes GetParent() method is called inside File.Delete(), so this test started to fail. Adding a new intermediate folder "some_folder" is the fastest way to make the test work again.
I can create a new issue with this if you think it is a real defect.
There was a problem hiding this comment.
Ah OK, thanks. Could you please create an issue for this problem and add a comment to the changed test case that refers to the issue?
There was a problem hiding this comment.
Done.
New issue is #395
fgreinacher
suggested changes
Oct 30, 2018
fgreinacher
approved these changes
Nov 5, 2018
|
Thanks again! |
|
Welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix the subject bug.