Skip to content

fix: incorrect thrown exception when calling Path.GetFullPath with white-space #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2023
Merged

fix: incorrect thrown exception when calling Path.GetFullPath with white-space #1030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b65d44c
Throw the correct ArgumentException when calling Path.GetFullPath wit…
vbreuss Aug 22, 2023
00d540d
Merge branch 'main' into topic/vb/throw-correct-exception-on-path-get…
vbreuss Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/TestableIO.System.IO.Abstractions.TestingHelpers/MockPath.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public override string GetFullPath(string path)
throw new ArgumentNullException(nameof(path), StringResources.Manager.GetString("VALUE_CANNOT_BE_NULL"));
}

if (path.Length == 0)
if (string.IsNullOrWhiteSpace(path))
{
throw CommonExceptions.PathIsNotOfALegalForm(nameof(path));
}
Expand Down
10 changes: 10 additions & 0 deletions tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockPathTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,16 @@ public void GetFullPath_EmptyValue_ShouldThrowArgumentException()
Assert.Throws<ArgumentException>(action);
}

[Test]
public void GetFullPath_WithWhiteSpace_ShouldThrowArgumentException()
{
var mockFileSystem = new MockFileSystem();

TestDelegate action = () => mockFileSystem.Path.GetFullPath(" ");

Assert.Throws<ArgumentException>(action);
}

[Test]
public void GetFullPath_WithMultipleDirectorySeparators_ShouldReturnTheNormalizedForm()
{
Expand Down